workorders: add ;continue to resume an in-progress order from the logbook - #1
Closed
simtel12 wants to merge 1 commit into
Closed
workorders: add ;continue to resume an in-progress order from the logbook#1simtel12 wants to merge 1 commit into
simtel12 wants to merge 1 commit into
Conversation
…book Reads the discipline logbook to recover the item and remaining quantity of an order already accepted (e.g. after a disconnect), instead of canceling and re-requesting one. Skips straight to turn-in when the logbook reports the order already complete.
Owner
Author
|
Retargeting to elanthia-online/dr-scripts:main directly instead of stacking on the fork's craft-workorders-fixes branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
;workorders <discipline> continueto resume an in-progress work order by reading the discipline logbook, instead of canceling and re-requesting one (e.g. after a disconnect). Recovers the recipe and remaining quantity from the logbook text, and skips straight to turn-in when the logbook reports the order already complete.Stacked on elanthia-online#7514 since
resume_work_orderrelies onlogbook_remaining, added there. Opened against this fork'scraft-workorders-fixesbranch to keep the diff isolated to just this feature; will retarget toelanthia-online:mainonce elanthia-online#7514 merges.Test plan
rspec spec/workorders_spec.rbpasses (106 examples, 0 failures)ruby -c workorders.licsyntax check clean